Skip to content

Handle usage-limit reset credits#219

Draft
andrei-hasna wants to merge 4 commits into
mainfrom
hotfix/usage-limit-reset-20260711
Draft

Handle usage-limit reset credits#219
andrei-hasna wants to merge 4 commits into
mainfrom
hotfix/usage-limit-reset-20260711

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds usage-limit reset credit protocol/types/schema artifacts and app-server consume RPC coverage.
  • Adds config-gated automatic reset handling and /usage TUI presentation for reset credits.
  • Includes focused tests for app-server rate-limit reset status/consume flow, backend-client parsing, config, and TUI rendering.
  • Adds a follow-up formatting-only commit after PR CI reported rustfmt drift.

Current branch state

  • Head: fe2ca838b11682c5443eaf6e00b4487b577b606d (Format usage reset hotfix).
  • Base: main.
  • Branch: hotfix/usage-limit-reset-20260711.
  • Ahead of origin/main by 3 commits.

Local validation on station02

  • git status --porcelain=v1 --branch: clean on hotfix/usage-limit-reset-20260711.
  • git rev-parse HEAD: fe2ca838b11682c5443eaf6e00b4487b577b606d.
  • git rev-list --left-right --count origin/main...HEAD: 0 3.
  • git diff --check origin/main..HEAD: passed.
  • Co-Authored-By trailer scan over origin/main..HEAD: absent.
  • shield review before the formatting commit: no security issues in staged changes.
  • Staged and branch diff secret-pattern scans: passed without printing candidate values.
  • Local Rust/codegen validation not run: cargo/rustfmt are not installed on station02, and local heavy Rust/Bazel builds were intentionally skipped for this prep pass.

Remote validation status

  • PR CI triggered automatically for the pushed branch.
  • Initial CI at 3b355368953599f5ae04628b7e457c78e123926e failed Format / etc and build-test due cargo fmt --check drift.
  • Formatting-only repair commit fe2ca838b11682c5443eaf6e00b4487b577b606d was pushed; wait for the new PR CI run on that head.

Required remote validation

Run in a Rust/Bazel-capable environment before merge:

just write-config-schema
just write-app-server-schema
just test -p codex-app-server-protocol
just test -p codex-app-server consume_rate_limit_reset_credit

Draft until those remote gates pass.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Queue state: deferred to the app-server/protocol lane, not merge-ready in the infra/skill lane.

Reason: this PR is draft, currently conflicts with main, and touches broad app-server/protocol/TUI/backend-client/core config surfaces. The body also says it is draft until remote gates pass.

Required before undraft/merge consideration:

  • rebase/restack on current main and resolve conflicts;
  • run all generated schema/config updates inside E2B only, including just write-config-schema and just write-app-server-schema where applicable;
  • run E2B-only focused validation for just test -p codex-app-server-protocol plus impacted app-server/TUI/backend-client tests;
  • obtain owner review and adversarial review on the exact final head.

No local compile/schema output from spark01 is accepted as evidence for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant