fix(secrets): preserve shell snapshot syntax during redaction - #471
Merged
Conversation
Agent: Herminia
Agent: Herminia
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Shell snapshot redaction could consume the trailing backslash from an escaped quote when a colon-delimited value contained a secret-like segment. The redacted file then became invalid Bash, so fresh
codewith execsessions discarded their shell snapshot after validation failed.What changed
Test plan
62066c71d: https://github.com/hasna/codewith/actions/runs/30709214729001883e63: https://github.com/hasna/codewith/actions/runs/30709541543Tracks OPE127-00016.