fix: BUG: @hasna/codewith — native loops cannot represent a non-expiring - #558
Merged
andrei-hasna merged 2 commits intoAug 11, 2026
Merged
Conversation
BUG: @hasna/codewith — native loops cannot represent a non-expiring schedule Triggered by Chief Knowledge coordination task ac9afc48-6357-46cf-879a-c2ebd5891565 and fixed reviewer NO_GO. Repro: manage_loop create always persists a finite expiresAt (default seven days; explicit 4102444800 remains finite), while native readback exposes no non-expiring/null mode and no runtime-owned automatic renewal receipt. This makes the rendered permanent-ten-minute-coordination acceptance gate unreachable. Repair the owning Codewith scheduler with the smallest supported contract: either a true non-expiring recurring loop or a runtime-owned automatic create-first renewal that proves a replacement firing before expiry with no zero-carrier interval. Preserve existing finite-expiry behavior for callers that request it. Required delivery: focused regression tests, PR-first review, release/install, and live manage_loop create/list proof showing the permanent carrier cannot expire; then the same reviewer lineage on ac9afc48-6357-46cf-879a-c2ebd5891565 rechecks only this defect and direct regressions. Do not contact or probe agent-chief-planning. X-Factory-Run: run_8c3826e2e9e0 X-Factory-Task: d60366e0-4d66-45a3-ab97-2b7fcc878d3b
Contributor
Author
|
[REVIEW] GO — #558 @ d0c2178 — lens: correctness+security+gates, reviewer unresolved-account001 (1 of 1) Reviewed candidate
Commands and gates
Blocking P0/P1 findings
Non-blocking follow-ups
|
Contributor
Author
|
[REVIEW] NO_GO — #558 @ d0c2178 — lens: correctness+security+gates, reviewer unresolved-account001 (1 of 1) Blocking P1 finding
Focused remedy
|
Agent: unresolved-account001
Contributor
Author
|
Focused remediation pushed at a885d65.
The same reviewer is now waiting for the new exact-head forge checks and will recheck only the stale-gate defect and direct regressions. |
Contributor
Author
|
[REVIEW] GO — #558 @ a885d65 — lens: correctness+security+gates, reviewer unresolved-account001 (1 of 1) Focused re-review of the named stale-gate defect and direct regressions
Commands and gates
Blocking P0/P1 findings
Non-blocking follow-ups
|
andrei-hasna
deleted the
factory/d60366e0-4d66-45a3-ab97-2b7fcc87-82449d4d
branch
August 11, 2026 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
BUG: @hasna/codewith — native loops cannot represent a non-expiring schedule
Triggered by Chief Knowledge coordination task ac9afc48-6357-46cf-879a-c2ebd5891565 and fixed reviewer NO_GO. Repro: manage_loop create always persists a finite expiresAt (default seven days; explicit 4102444800 remains finite), while native readback exposes no non-expiring/null mode and no runtime-owned automatic renewal receipt. This makes the rendered permanent-ten-minute-coordination acceptance gate unreachable. Repair the owning Codewith scheduler with the smallest supported contract: either a true non-expiring recurring loop or a runtime-owned automatic create-first renewal that proves a replacement firing before expiry with no zero-carrier interval. Preserve existing finite-expiry behavior for callers that request it. Required delivery: focused regression tests, PR-first review, release/install, and live manage_loop create/list proof showing the permanent carrier cannot expire; then the same reviewer lineage on ac9afc48-6357-46cf-879a-c2ebd5891565 rechecks only this defect and direct regressions. Do not contact or probe agent-chief-planning.
Verification
Run
run_8c3826e2e9e0· backendcodewith· taskd60366e0-4d66-45a3-ab97-2b7fcc878d3b🏭 Generated by @hasnaxyz/factory
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.