feat(solcast): add Solcast solar PV forecast connector#317
Merged
2 commits merged intoJul 7, 2026
Merged
Conversation
Implement @hasna/connect-solcast with API client, CLI, types, registry entry, and focused client tests against the public Solcast REST API.
Add Environment Variables, CLI Commands, and Data Storage sections for dashboard auth detection; wire install_date and terrain_shading options.
Contributor
Author
|
Automated merge review for task Validation evidence:
Merge blockers found by adversarial review:
Recommended fix: update Solcast config handling to use the repo's profile-compatible connector config convention, make read-only config reads side-effect-free, and write any credential-bearing files/directories with owner-only permissions. Add focused tests covering dashboard/profile-saved key lookup and credential file mode. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@hasna/connect-solcastpackage underconnectors/solcast/with typed REST client, Commander CLI, config utils, and docssolcastin Data & Analytics (src/lib/connectors/data-analytics.ts)https://api.solcast.com.auTest plan
connectors/solcast:bun run typecheck,bun run build,bun test src/api/client.test.ts(5 pass)bun run typecheck,bun run build,bun test src/lib/registry.test.ts(28 pass)CLI > eventsisolation test, unrelated to solcast)