Fix TypeScript declaration publishing#1
Closed
andrei-hasna wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Closing as superseded / already fixed on main. This PR (2026-06-23, "Fix TypeScript declaration publishing") is obsolete: its intent is fully implemented on current Evidence:
Only element not on main: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
./storagetypes metadata and aprepackbuild hook so plainnpm packincludes declarations from a clean checkoutValidation
rm -rf dist && npm pack --dry-run --jsonbun run validate:packnpm publish --dry-run --jsonbun test./node_modules/.bin/biome check package.json tsconfig.types.json scripts/build-types.ts scripts/validate-package.ts@hasna/logsand@hasna/logs/storageunder NodeNext and BundlerReview
npm packbypassed validation; reconciled withprepack: bun run buildand revalidated clean pack output