Skip to content

docs: sync goal-wrapper migration and changelog for 0.3.58–0.3.60#41

Merged
andrei-hasna merged 1 commit into
mainfrom
openloops/open-loops/7c550877-f798-4dd8-a184-b8b944e69dfa-fc828a94
Jul 6, 2026
Merged

docs: sync goal-wrapper migration and changelog for 0.3.58–0.3.60#41
andrei-hasna merged 1 commit into
mainfrom
openloops/open-loops/7c550877-f798-4dd8-a184-b8b944e69dfa-fc828a94

Conversation

@andrei-hasna

Copy link
Copy Markdown
Contributor

Summary

  • Document nested workflow goal deadlock prevention and the preferred loop-level --goal pattern for workflow loops in README Goals.
  • Add loops workflows migrate-goal-wrappers beside migrate-agent-timeouts in README and docs/USAGE with append-only migration semantics (--apply, --archive-old).
  • Expand compact CHANGELOG 0.3.58–0.3.60 entries into full Fixed/Added sections; note 0.3.60 durable-agent path superseded by 0.4.9 codewith exec.

Test plan

  • bun run typecheck
  • bun test (618/619 pass; drainTodosTaskRoutes freshness close times out on main — pre-existing, unrelated to docs)
  • rg confirms codewith agent start references are historical-only
  • loops workflows migrate-goal-wrappers --help spot-check

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Worker review for task 6efb3e93-f6c6-4d88-a7f3-eb7728bb0360: not merged.

Evidence:

  • Live PR state: OPEN, mergeStateStatus=DIRTY, mergeable=CONFLICTING. Local merge simulation conflicts in README.md and docs/USAGE.md.
  • Current GitHub checks are green, but they are from stale head ffdf0e7 before resolving current main.
  • Conflict inspection showed docs drift between the PR goal-wrapper migration docs and newer main docs; a straightforward docs reconciliation is possible, but I did not push an unvalidated branch update.
  • Validation after installing locked dependencies with TMPDIR=/tmp: bun run typecheck passed; bun run build passed; full bun test failed.
  • Failing local tests on the merged PR state: "loops CLI > todos task event handler dedupes PR backlog tasks by GitHub fingerprint" and "drainTodosTaskRoutes freshness close > closes a merged-PR task out of the queue instead of re-skipping it" timed out.
  • I reproduced both focused failures on detached origin/main at 84488ee, so these appear to be existing base-branch validation blockers rather than docs PR regressions.

Adversarial self-review: the docs change itself is small and conflict resolution looked low risk, but merging would leave unresolved PR conflicts and red local validation against current main. Policy gate says do not merge until conflicts are resolved and validation is green, or the failing base-branch tests are explicitly waived by a maintainer.

Document nested workflow goal deadlock prevention, migrate-goal-wrappers
append-only migration beside migrate-agent-timeouts, and expand compact
0.3.58–0.3.60 changelog entries (noting 0.3.60 superseded by 0.4.9 exec).
@andrei-hasna
andrei-hasna force-pushed the openloops/open-loops/7c550877-f798-4dd8-a184-b8b944e69dfa-fc828a94 branch from ffdf0e7 to 2750b9c Compare July 6, 2026 01:51
@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Resolved the docs conflicts against current main.\n\nUpdated PR head to 2750b9c on openloops/open-loops/7c550877-f798-4dd8-a184-b8b944e69dfa-fc828a94; GitHub now reports mergeStateStatus: CLEAN and mergeable: MERGEABLE. The diff remains scoped to CHANGELOG.md, README.md, and docs/USAGE.md, preserving the goal-wrapper migration docs and the 0.3.58-0.3.60 changelog expansion while keeping current-main timeout/direct-agent migration wording.\n\nValidation:\n- git diff --check origin/main...HEAD passed\n- conflict-marker scan over owned docs passed\n- bun run typecheck passed\n- bun run build passed\n- bun test src/cli/index.test.ts -t "docs include the OSS task route drain safety recipe" passed\n- bun test src/cli/index.test.ts -t "workflows migrate-goal-wrappers" passed\n- GitHub CI passed: bun (ubuntu-latest), bun (macos-latest)\n\nNote: a full local bun test run produced 641 pass / 2 fail in existing route backlog/freshness tests, with no source/package changes in this branch. Focused docs/migration tests and required checks passed. Adversarial review found no blocking issues.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Worker merge review evidence (2026-07-06):\n\n- PR is docs-only: CHANGELOG.md, README.md, docs/USAGE.md (112 additions, 21 deletions).\n- GitHub state: OPEN, non-draft, MERGEABLE, mergeStateStatus=CLEAN; head 2750b9c; base 84488ee.\n- Required GitHub checks passed: bun (ubuntu-latest), bun (macos-latest).\n- Local validation on PR head: git diff --check passed; bun run typecheck passed; bun run test:boundary passed; focused goal-wrapper tests passed (migrate-goal-wrappers CLI tests; nested goal store/runner tests).\n- Local full bun test currently has two route/PR-backlog failures, but both reproduce unchanged on origin/main and are outside this docs-only diff.\n- Independent adversarial reviewer found no doc accuracy issues and recommended merge.\n\nProceeding to merge because PR-specific validation and merge policy are satisfied.

@andrei-hasna
andrei-hasna merged commit 49aa8c4 into main Jul 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant