Fix generated path handling for OpenLoops route worktrees#75
Fix generated path handling for OpenLoops route worktrees#75andrei-hasna wants to merge 4 commits into
Conversation
903f0d7 to
07c500d
Compare
|
OpenLoops worker review is blocking merge for now. Independent adversarial reviewer found a managed-worktree hygiene bug in this PR:
Required before merge: derive the repo slug from the managed worktree repo segment, or otherwise from the git top-level repository identity, for ~/.hasna/loops/worktrees//[/relativeCwd], and add focused hygiene test coverage for managed worktree cwd paths. Validation otherwise completed on a local merge of origin/main ff62f37 + PR head 07c500d: focused tests passed, typecheck passed, boundary scan passed, build passed, and the full suite passed with bun test --timeout=15000 (713 pass, 15 skip). The default local bun test run has a separate 5s timeout in existing route tests that reproduces on unmodified origin/main or under local load, so it is recorded as base/environment timing rather than this PR regression. |
|
Closing unmerged at the bounded repair/review cap. Exact head: 70142c8 Ubuntu, PostgreSQL storage, and runner-image security passed. macOS failed a PR-introduced frozen-scope case: canonical /private/var repository roots were compared with lexical /var cwd paths, so a valid ..sdk subdirectory was treated as outside the repository and its relative cwd was dropped. A separate drain-test timeout is pre-existing and is not the reason for closure. The repair cycle is capped; no additional implementation/review loop will be opened on this PR. The pushed branch and canonical recovery worktree are preserved so a later replacement can be a narrow canonical-path fix. Main is unchanged. Reopen is the rollback. |
Summary
Validation
Review
Independent adversarial reviewer found a nested generated-dir gap; fixed by scanning every relative path segment and adding src/lib/git-project.test.ts coverage for repo/packages/sdk/.tmp and .bun-cache.
Task: e67e4e71-d27b-40e2-81e9-a7362e9e5cc7