ci: hasna/models has no GitHub Actions workflow — add a test+typecheck - #9
ci: hasna/models has no GitHub Actions workflow — add a test+typecheck#9andrei-hasna wants to merge 2 commits into
Conversation
CI: hasna/models has no GitHub Actions workflow — add a test+typecheck gate on pull_request This repo has no GitHub Actions workflow at all — there is no automated gate on pull requests, so nothing catches a broken build or a failing test before merge. Add a minimal, correct CI workflow at .github/workflows/ci.yml for open-models (github.com/hasna/models). Trigger on push and pull_request to the default branch. Use actions/checkout and oven-sh/setup-bun; run `bun install --frozen-lockfile` (fall back to `bun install` if there is no lockfile), then ONLY the scripts that actually exist in package.json among typecheck / build / test — skip any that are absent, do not invent scripts. Keep it minimal and GREEN: if a script exists but is already failing on the default branch, do not paper over it — either scope the workflow to the scripts that pass and say so in the PR body, or fix the failure if it is trivial and clearly in scope. Verify: confirm the workflow file parses (valid YAML, correct action refs) and that each command you reference is a real script in package.json. Scope: the workflow file only, optionally a CI badge line in README. Do NOT modify product code. Open a PR against the default branch; do not merge. X-Factory-Run: run_342f7a321266 X-Factory-Task: 41e57872-8ab7-4f2a-a225-a7dc29a2566a
|
[REVIEW] NO_GO — #9 @ 81d4ee5 — lens: correctness+security+gates, reviewer Augustus (1 of 1) What I actually ran:
What I read:
Blocking P0/P1 findings:
Non-blocking follow-ups:
|
Agent: Augustus
|
Follow-up fix for the
|
|
[DISPOSITION] CLOSED by faustus (lineage agent-ceo) — superseded, empty diff — 2026-07-31. This PR's goal is already on Closing rather than fixing, because there is nothing to fix. Nothing is destroyed: the diff is empty, the branch is untouched, and a close is reversible if this reading is wrong. Verified before closing — #8 |
Objective
CI: hasna/models has no GitHub Actions workflow — add a test+typecheck gate on pull_request
This repo has no GitHub Actions workflow at all — there is no automated gate on pull requests, so nothing catches a broken build or a failing test before merge.
Add a minimal, correct CI workflow at .github/workflows/ci.yml for open-models (github.com/hasna/models). Trigger on push and pull_request to the default branch. Use actions/checkout and oven-sh/setup-bun; run
bun install --frozen-lockfile(fall back tobun installif there is no lockfile), then ONLY the scripts that actually exist in package.json among typecheck / build / test — skip any that are absent, do not invent scripts.Keep it minimal and GREEN: if a script exists but is already failing on the default branch, do not paper over it — either scope the workflow to the scripts that pass and say so in the PR body, or fix the failure if it is trivial and clearly in scope.
Verify: confirm the workflow file parses (valid YAML, correct action refs) and that each command you reference is a real script in package.json.
Scope: the workflow file only, optionally a CI badge line in README. Do NOT modify product code. Open a PR against the default branch; do not merge.
Verification
Run
run_342f7a321266· backendcodewith· task41e57872-8ab7-4f2a-a225-a7dc29a2566a🏭 Generated by @hasnaxyz/factory
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.