Skip to content

ci: hasna/models has no GitHub Actions workflow — add a test+typecheck - #9

Closed
andrei-hasna wants to merge 2 commits into
mainfrom
factory/41e57872-8ab7-4f2a-a225-a7dc29a2-242cabb3
Closed

ci: hasna/models has no GitHub Actions workflow — add a test+typecheck#9
andrei-hasna wants to merge 2 commits into
mainfrom
factory/41e57872-8ab7-4f2a-a225-a7dc29a2-242cabb3

Conversation

@andrei-hasna

@andrei-hasna andrei-hasna commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Objective

CI: hasna/models has no GitHub Actions workflow — add a test+typecheck gate on pull_request

This repo has no GitHub Actions workflow at all — there is no automated gate on pull requests, so nothing catches a broken build or a failing test before merge.

Add a minimal, correct CI workflow at .github/workflows/ci.yml for open-models (github.com/hasna/models). Trigger on push and pull_request to the default branch. Use actions/checkout and oven-sh/setup-bun; run bun install --frozen-lockfile (fall back to bun install if there is no lockfile), then ONLY the scripts that actually exist in package.json among typecheck / build / test — skip any that are absent, do not invent scripts.

Keep it minimal and GREEN: if a script exists but is already failing on the default branch, do not paper over it — either scope the workflow to the scripts that pass and say so in the PR body, or fix the failure if it is trivial and clearly in scope.

Verify: confirm the workflow file parses (valid YAML, correct action refs) and that each command you reference is a real script in package.json.

Scope: the workflow file only, optionally a CI badge line in README. Do NOT modify product code. Open a PR against the default branch; do not merge.

Verification

  • policy source: base a22e758 (immutable commit — agent-proof)
  • ⚠️ GATE-INTEGRITY: agent touched verify-bearing config — REVIEW (.github/workflows/ci.yml)
  • containment: env — allowlist env, non-login shell, run-scoped HOME (registry auth seeded for install)
  • install: pass
  • typecheck: pass
  • build: pass
  • test: pass
  • doctor (ci): ok — 11 checks passed (1 advisory)

Run run_342f7a321266 · backend codewith · task 41e57872-8ab7-4f2a-a225-a7dc29a2566a
🏭 Generated by @hasnaxyz/factory


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

CI: hasna/models has no GitHub Actions workflow — add a test+typecheck gate on pull_request

This repo has no GitHub Actions workflow at all — there is no automated gate on pull requests, so nothing catches a broken build or a failing test before merge.

Add a minimal, correct CI workflow at .github/workflows/ci.yml for open-models (github.com/hasna/models). Trigger on push and pull_request to the default branch. Use actions/checkout and oven-sh/setup-bun; run `bun install --frozen-lockfile` (fall back to `bun install` if there is no lockfile), then ONLY the scripts that actually exist in package.json among typecheck / build / test — skip any that are absent, do not invent scripts.

Keep it minimal and GREEN: if a script exists but is already failing on the default branch, do not paper over it — either scope the workflow to the scripts that pass and say so in the PR body, or fix the failure if it is trivial and clearly in scope.

Verify: confirm the workflow file parses (valid YAML, correct action refs) and that each command you reference is a real script in package.json.

Scope: the workflow file only, optionally a CI badge line in README. Do NOT modify product code. Open a PR against the default branch; do not merge.

X-Factory-Run: run_342f7a321266
X-Factory-Task: 41e57872-8ab7-4f2a-a225-a7dc29a2566a
@andrei-hasna

Copy link
Copy Markdown
Contributor Author

[REVIEW] NO_GO — #9 @ 81d4ee5 — lens: correctness+security+gates, reviewer Augustus (1 of 1)

What I actually ran:

  • git log --oneline origin/main..HEAD exit 0: one PR commit, 81d4ee5 ci: hasna/models has no GitHub Actions workflow — add a test+typecheck.
  • git diff origin/main...HEAD --stat exit 0: one changed file, .github/workflows/ci.yml, 24 insertions.
  • git diff --full-index --find-renames origin/main...HEAD -- .github/workflows/ci.yml exit 0.
  • git merge-tree $(git merge-base origin/main HEAD) origin/main HEAD exit 0, but output an add/add conflict for .github/workflows/ci.yml.
  • git diff --check origin/main...HEAD exit 0.
  • gh pr view 9 --repo hasna/models --json ... exit 0: mergeable was CONFLICTING.
  • bun install exit 0.
  • bun run typecheck exit 0.
  • bun run build exit 0.
  • bun test exit 0; 41 pass, 0 fail.

What I read:

  • Full PR diff for .github/workflows/ci.yml.
  • The added workflow file at PR head.
  • Surrounding repo configuration: package.json, tsconfig.json, bun.lock presence, README.md, repo file layout, and current origin/main:.github/workflows/ci.yml.

Blocking P0/P1 findings:

Non-blocking follow-ups:

  • None.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

Follow-up fix for the NO_GO review:

  • Pushed 649cb9dfe8f47686bf19da8db280f817f0a96397 to factory/41e57872-8ab7-4f2a-a225-a7dc29a2-242cabb3.
  • Synced PR ci: hasna/models has no GitHub Actions workflow — add a test+typecheck #9 with current main at 2432d5c63d6e64a31d456dc5cbd707d97c656fd4.
  • Resolved the .github/workflows/ci.yml add/add conflict by keeping the already-landed current-main workflow, so the branch now has no remaining file diff against main.
  • Verified after the fix: bun install exit 0, bun run typecheck exit 0, bun run build exit 0, bun test exit 0.
  • Ran a redacting staged-diff secrets scan before commit: exit 0. The repository pre-push hook also scanned the pushed commits.
  • Rechecked PR state after push: gh pr view reports mergeable: MERGEABLE.

@andrei-hasna

Copy link
Copy Markdown
Contributor Author

[DISPOSITION] CLOSED by faustus (lineage agent-ceo) — superseded, empty diff — 2026-07-31.

This PR's goal is already on main. #8 landed the same .github/workflows/ci.yml at 2026-07-31T15:34:00Z (the file is on main now, 466 bytes, blob 8672f2845cdd), and GitHub reports this PR as +0/-0 across 0 changed files — its tree is identical to base, so there is no work here to preserve. The standing NO_GO recorded exactly this: an add/add conflict against a path main already had.

Closing rather than fixing, because there is nothing to fix. Nothing is destroyed: the diff is empty, the branch is untouched, and a close is reversible if this reading is wrong.

Verified before closing — #8 MERGED, ci.yml present on main, this PR OPEN/MERGEABLE with 0 changed files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant