fix: authenticate registry provenance verification - #94
Merged
Conversation
Agent: Trebius
Contributor
Author
|
[REVIEW] GO — #94 @ debf49b — lens: correctness+security+gates, reviewer Trebius (1 of 1) Focused re-review covered only the blocking private-registry authentication defect named on #93, its fix, and direct regressions. Verified:
Blocking P0/P1 findings: none. Non-blocking follow-ups: none. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm viewcalls through the package vault pathContext
Follow-up to #93. The original PR merged while its independent review was running. The review found that restricted packages could publish successfully and then fail provenance verification because the post-publish registry read was unauthenticated.
Verification
bun run typecheck— exit 0, 0 errorsbun run test— exit 0, 1087 pass, 1 skip, 0 fail, 6702 expect() calls across 85 files63d8a95ad24b0af24ffa25a2d172cd53749f9084is byte-identical to the tree that passed those gatesNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.