Skip to content

chore(deps-dev): bump @types/node from 22.19.21 to 26.1.0#109

Merged
hasparus merged 2 commits into
mainfrom
dependabot/npm_and_yarn/types/node-26.0.1
Jul 2, 2026
Merged

chore(deps-dev): bump @types/node from 22.19.21 to 26.1.0#109
hasparus merged 2 commits into
mainfrom
dependabot/npm_and_yarn/types/node-26.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 1, 2026

Copy link
Copy Markdown
Contributor

Bumps @types/node from 22.19.21 to 26.1.0.

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 1, 2026

@hasparus hasparus left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green on all functional checks (lint, typecheck, build, Playwright e2e all pass) despite the @types/node 22→26 major bump — typecheck passing confirms no breaking type changes affect this codebase. The only failing job step is Deploy Preview to Vercel (deploy.mjs: missing --token), which fails identically on every open Dependabot PR because secrets aren't available in dependabot-triggered pull_request runs — a pre-existing CI gap unrelated to this bump. Approving and merging.


Generated by Claude Code

hasparus commented Jul 1, 2026

Copy link
Copy Markdown
Owner

·@·d·ependabot r·ebase


Generated by Claude Code

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/types/node-26.0.1 branch from 0679acd to f3463eb Compare July 1, 2026 10:12
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 22.19.21 to 26.1.0.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.0.1
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot changed the title chore(deps-dev): bump @types/node from 22.19.21 to 26.0.1 chore(deps-dev): bump @types/node from 22.19.21 to 26.1.0 Jul 1, 2026
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/types/node-26.0.1 branch from f3463eb to 8979b5a Compare July 1, 2026 19:54
Dependabot PRs run from the same repo (not a fork), so the deploy
step's fork-only guard let it through even though GitHub withholds
repository secrets from dependabot-actor runs. That caused
deploy.mjs to fail with 'missing --token'. Treat dependabot[bot]
runs the same as fork PRs: build/lint/typecheck/test still run,
but preview deploy and lighthouse are skipped until a maintainer
adds the 'trusted' label.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

hasparus commented Jul 2, 2026

Copy link
Copy Markdown
Owner

CI was failing on build-and-deploy with deploy.mjs: missing --token, unrelated to this dependency bump (build/lint/typecheck/test all passed). Root cause: Dependabot PRs run from a branch in this repo (not a fork), so the "fork-only" guard on the Vercel preview-deploy step let the step run — but GitHub withholds repository secrets from dependabot[bot]-authored runs, so VERCEL_TOKEN was empty.

Pushed a fix that also excludes github.actor == 'dependabot[bot]' from the "trusted" condition (matching the pattern already used for OG_IMAGE_SECRET), so build/lint/typecheck/test still run but the deploy/lighthouse steps are skipped until a maintainer labels the PR trusted. Re-running CI now.


Generated by Claude Code

@hasparus hasparus merged commit 2668d2e into main Jul 2, 2026
3 checks passed
@dependabot dependabot Bot deleted the dependabot/npm_and_yarn/types/node-26.0.1 branch July 2, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant