community: add hindi translation for CONTRIBUTING.md (fix #5851) #5881
Conversation
|
Beep boop! 🤖 Hey @akash1997, thanks for your PR! One of my human friends will review this PR and get back to you as soon as possible. Stay awesome! 😎 |
|
I don't think I have access to add the |
shraddhaag
changed the title
Naveenaidu
left a comment
Naveenaidu
left a comment
There was a problem hiding this comment.
Thank you very much for providing the Hindi Translation. We really appreciate the help. The translation is very apt and awesome :)
There are few changes, that needs to be done - After which the PR would be good to go.
cc: @marionschleifer
|
Thanks @Naveenaidu for reviewing the translated doc and suggesting the changes! Have made those changes, except the DM one. Waiting for the reply from @marionschleifer for that. If we are going to remove that line, I will remove it in the original file as well. |
|
@akash1997 Awesomeee! Thanks for making the changes. Also, once Marion replies to the DM question, and that query is resolved. Could you please squash your commits into 1? |
|
@Naveenaidu Can we merge this for now and resolve the DM question as a part of another issue? Because I'm pretty sure the same line is copied in other translation files too, we will have to remove the line in all of them if @marionschleifer wants it to be removed. |
|
Hi, @akash1997 I just checked that there is no DM question line in CONTRIBUTING.md. I guess it was removed in some other PR. |
|
@Naveenaidu Have removed the DM line and squashed the commits into 1. |
Naveenaidu
left a comment
Naveenaidu
left a comment
There was a problem hiding this comment.
Awesomeeee! Thank a lot for making the requested changes ❤️
The PR LGTM 👍
Naveenaidu
changed the title
Naveenaidu
changed the title
|
@Naveenaidu @marionschleifer Can we please merge this? Its been over a week since the changes are approved |
6 participants
Description
Add Hindi translation for CONTRIBUTING.md
Close: #5851
Changelog
CHANGELOG.mdis updated with user-facing content relevant to this PR. If no changelog is required, then add theno-changelog-requiredlabel.Affected components
Catalog upgrade
Does this PR change Hasura Catalog version?
Metadata
Does this PR add a new Metadata feature?
GraphQL
Breaking changes