fix: Make PowerShell multiline code guidance clearer#1355
Merged
Conversation
Explain that PowerShell 7 here-strings can pass multiline snippets directly to --code without a temporary file, while keeping --code-file guidance for Windows PowerShell 5.1 and launchers that do not preserve inline code exactly.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughUpdates PowerShell shell-quoting and ChangesPowerShell Quoting and Parameters Documentation Updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.md`:
- Around line 28-29: The `--parameters` flag documentation is inconsistent
across multiple files: the SKILL.md files state to pass an object instead of a
JSON string, but the PowerShell examples in playmode-automation-powershell.md
references contradict this by using JSON strings. First, clarify the
documentation at lines 28-29 in
Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.md,
.agents/skills/uloop-execute-dynamic-code/SKILL.md, and
.claude/skills/uloop-execute-dynamic-code/SKILL.md to explicitly specify the
canonical form for `--parameters`. Then, update the PowerShell parameter
examples at lines 76-128 in
Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/references/playmode-automation-powershell.md,
.agents/skills/uloop-execute-dynamic-code/references/playmode-automation-powershell.md,
and
.claude/skills/uloop-execute-dynamic-code/references/playmode-automation-powershell.md
to use the same form as documented in the SKILL.md files, ensuring all
invocation examples are consistent.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 7fcc57e8-5417-4974-a8be-4c78015c8273
📒 Files selected for processing (6)
.agents/skills/uloop-execute-dynamic-code/SKILL.md.agents/skills/uloop-execute-dynamic-code/references/playmode-automation-powershell.md.claude/skills/uloop-execute-dynamic-code/SKILL.md.claude/skills/uloop-execute-dynamic-code/references/playmode-automation-powershell.mdPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/SKILL.mdPackages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill/references/playmode-automation-powershell.md
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 6 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
hatayama
changed the title
Align the PowerShell skill guidance with the CLI object parameter contract and use the current Unity object lookup API in the new multiline example.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--code-fileguidance for Windows PowerShell 5.1 and launchers that cannot preserve inline code exactly.User Impact
--codeis enough and when--code-fileis still the safer option.Changes
.agentsskill copies from the source skill files.Verification
git diff --checkrg -n "here-string|code-file|old .*cmd|PowerShell 5.1|native Go" Packages/src/Editor/FirstPartyTools/ExecuteDynamicCode/Skill .claude/skills/uloop-execute-dynamic-code .agents/skills/uloop-execute-dynamic-code -S