fix: compile-consistency — external scene hold, compile wait/TTL align, API Update guidance - #1760
Conversation
|
Warning Review limit reached
Next review available in: 35 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (15)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
LGTM (umbrella). The diff is exactly the union of the three reviewed and individually-LGTMed sub-PRs (#1757 external scene unfocused hold + VibeLogger observability, #1758 compile wait 10m / result TTL 20m alignment with recovery guidance, #1759 API Update consent guidance A+B-lite), with no extra changes. Follow-ups are recorded in the body (Disallow warning backoff, narrow catch, ODE scheduler slot residual, decline-direction API-update experiment with the reflection-gated native test hooks requiring explicit approval). Machine verification recap: #1757 passed a clean gate on real hardware (unfocused launch, held probe observed true, discard, single focus click, no native dialog, quiet reload confirmed via vibe timeline + Editor.log). Merge to v3-beta once CI (incl. Compile Check) is green. |
Summary
Group 5 umbrella for compile / Editor dialog consistency on top of
v3-beta.Merged sub-PRs:
launch -rUser Impact
Follow-ups (out of this umbrella / separate tasks)
DisallowAutoRefreshwarnings spam every 0.5s reconcile tick during prolonged kCodeReload, rate-limit themcatch (Exception)on Disallow/Allow once the real Unity exception type for kCodeReload is confirmed in the fieldDynamicCodeExecutionSchedulerslot across abandoned clients / domain reload —Another execution is already in progresswith idle Roslyn worker; full Unity quit clears it (group-3 residual; see/tmp/claude-shared/pr-5-2-ode-slot-diagnosis.md)DoesCommandLineIndicateAPIUpdatingShouldBeDeclined/ NoConsent. Fable also verified native test hooks in the 2022.3.62f3 binary:MakeNextAPIUpdateOfferReturn/ResetNextAPIUpdateOfferReturn(reflection-gated; needs hatayama approval; separate task). Do not pursue auto-accept or unapproved reflection in product paths.Test plan
uloop compilestill completes; timeout NextActions mention API Update consentMade with Cursor