chore: Fix the skill-target layout test that pointed at a removed directory - #2022
Merged
hatayama merged 2 commits intoJul 27, 2026
Conversation
The test built its fixture under .cursor, which stopped being a skill target in #1983. Detection skipped the directory entirely, so the test asserted on an empty result and failed on the count before it could check the layout state it exists to verify. .claude is the directory every other single-target test in this fixture uses.
Contributor
📝 WalkthroughWalkthroughThe grouped-layout detection test now points its empty flat managed directory fixture at ChangesTool skill layout tests
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
AreSkillsInstalled_WhenLegacyManagedDirectoryIsEmpty_StillDetectsFlatLayout still named .cursor. It passes either way because the API takes the directory name directly, but keeping a removed target in a fixture invites the same confusion the sibling test just caused. .codex is what the neighbouring case uses.
hatayama
merged commit Jul 27, 2026
71161ca
into
feature/cli-discoverability-integration
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToolSkillSynchronizerTests, which was failing for a reason unrelated to what it verifies.User Impact
None — test-only. Nothing about skill detection or installation changes.
Changes
DetectTargets_WhenGroupedLayoutRequested_DetectsEmptyFlatManagedDirectoriesbuilt its fixture under.cursor. That directory stopped being a skill target when the target list was trimmed to Claude Code, Codex CLI, Common and Antigravity, so detection skipped it and returned no targets at all. The test then failed onAssert.That(detectedTargets.Length, Is.EqualTo(1))before reaching the layout assertions it exists for.The fixture now uses
.claude, the directory every other single-target test in this file uses, so the test exercises the grouped-versus-flat layout detection it was written to cover.SkillInstallLayoutTestsnamed the same removed directory in one fixture. It passed either way because that API takes the directory name directly, but it is the same staleness, so it now uses.codexlike the case beside it. No.cursorreference is left in the tests.Triage result: the failure was in the test, not in the product.
SkillTargetDetectorcorrectly ignores directories that are not skill targets.Verification
uloop run-tests(EditMode,ToolSkillSynchronizerTests|SkillInstallLayoutTests): 70/70 passed. Before this changeToolSkillSynchronizerTestswas 51/52 withExpected: 1 But was: 0at line 907.