feat: report last observed compile status in COMPILE_WAIT_TIMEOUT - #2035
Conversation
Include IsCompiling/IsUpdating/IsDomainReloadInProgress and WaitedMs in the timeout error details so callers can see why the wait ended. Co-authored-by: Cursor <cursoragent@cursor.com>
When the busy running tool is compile, guide callers that their own prior COMPILE_WAIT_TIMEOUT can reattach on retry — not unity-compile. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 6 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Unit coverage of compileWaitTimeoutDetails alone left the run.go / compile_attach.go wiring untested; nil lastStatus or zero WaitedMs would still pass the suite. Assert IsCompiling and WaitedMs on the existing timeout stderr envelopes so those call sites stay wired. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Addressed review feedback on test discriminating power:
|
Summary
COMPILE_WAIT_TIMEOUTnow includes the last observed compile status flags and how long the CLI waited.UNITY_SERVER_BUSYwhile the running tool iscompileexplains that a caller's own prior timeout can reattach on retry.User Impact
IsCompiling/IsUpdating/IsDomainReloadInProgressandWaitedMs. Busy responses for a runningcompiletool also point to the reattach recovery path without promising it for unrelatedunity-compilebusy states.Changes
waitForCompileCompletionWithDepsreturns the last observed*compileStatusResponse(nil when none).EditorActivityprecedent on busy errors.runningToolName == "compile".cli/commonchange.Verification
scripts/check-go-cli.shpassed.scripts/stamp-release-inputs.shrun and included.dist/darwin-arm64/uloop compile --compile-wait-timeout-seconds 1 --force-recompile→ Details{IsCompiling: true, WaitedMs: 1001, ...}.