fix: GetWorkerActionsByWorkerActionHash query optimization - #4138
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Optimizes the GetWorkerActionsByWorkerActionHash SQLC query to avoid expensive scans on _ActionToWorker in high worker-churn environments by selecting a single “representative” worker per action hash and joining from that worker to actions.
Changes:
- Replaced
SELECT DISTINCT ... FROM Worker ... JOIN _ActionToWorker ...with a representative-worker approach usingunnest(actionHashes)+ indexed lookup of one worker ID per hash. - Added an explanatory note documenting the correctness assumption (same
actionHash⇒ same action set) and the performance motivation.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/repository/sqlcv1/workers.sql | Rewrites GetWorkerActionsByWorkerActionHash to use a representative worker per hash (avoids _ActionToWorker seq scans). |
| pkg/repository/sqlcv1/workers.sql.go | Regenerated SQLC output reflecting the updated query and emitted note. |
Files not reviewed (1)
- pkg/repository/sqlcv1/workers.sql.go: Language not supported
abelanger5
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DISTINCT in GetWorkerActionsByWorkerActionHash seems to cause a sequence scan on _ActionToWorker leading to high CPU on high worker churn systems.
Old query
New query
Type of change
What's Changed
Checklist
Changes have been:
🤖 AI Disclosure