fix: redact RabbitMQ URL in dial failure logs - #4418
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Benchmark resultsCompared against |
igor-kupczynski
force-pushed
the
redact-rabbitmq-url-in-dial-logs
branch
from
July 14, 2026 14:38
9a9a781 to
45c90d6
Compare
igor-kupczynski
force-pushed
the
redact-rabbitmq-url-in-dial-logs
branch
from
July 14, 2026 14:40
45c90d6 to
498f696
Compare
igor-kupczynski
marked this pull request as ready for review
July 14, 2026 14:42
grutt
approved these changes
Jul 14, 2026
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cannot (re)dialerror logs ininternal/msgqueue/rabbitmq/channel_pool.goprinted the raw RabbitMQ connection URL, potentially leaking the username and password into logs (and any log aggregation) whenever a dial failed — e.g. during credential rotation.redactURLhelper (stdlibnet/url+URL.Redacted()) that masks the password asxxxxx; unparseable URLs log<unparseable url>instead of the raw value. The redacted URL is computed once innewChannelPooland used at both log sites, keeping host/port visible for debugging.