fix(dashboard): add copy to run page on redirect from trigger - #4423
Merged
Conversation
…le stop getting scared
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the dashboard run-trigger flow by showing a more helpful “wait for replication” message on the run detail page when a newly-triggered run briefly 404s (before analytics replication completes), with a refresh action to retry.
Changes:
- Adds a validated search flag on the tenant run route to indicate the user was redirected from a trigger action.
- Sets that flag when navigating to a run immediately after triggering from the workflow page.
- Updates the run detail page to render a specialized 404 state (with “Try refreshing”) and enhances
ResourceNotFoundto support custom primary actions/icons.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/app/src/router.tsx | Adds validateSearch schema for the run route and exports tenantRunRoute for typed useSearch() usage. |
| frontend/app/src/pages/main/v1/workflows/$workflow/components/trigger-workflow-form.tsx | Passes a search flag when redirecting to the run detail page after triggering a run. |
| frontend/app/src/pages/main/v1/workflow-runs-v1/$run/index.tsx | Shows a special 404 experience for trigger-redirected runs and allows refetch without flashing the full-page spinner. |
| frontend/app/src/pages/error/components/resource-not-found.tsx | Extends the error component to support a primary action override and icon spin behavior. |
abelanger5
approved these changes
Jul 15, 2026
juliusgeo
reviewed
Jul 15, 2026
|
|
||
| // Treat malformed IDs (often 400) and missing resources (404) as not found. | ||
| if (status === 400 || status === 404) { | ||
| if (status === 404 && wasRedirectedFromTrigger) { |
Contributor
Author
There was a problem hiding this comment.
it's just a weird diff, this got moved down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds some copy to the run detail page when you get redirected there after triggering a run from the dashboard and getting a 404, saying to just wait a bit
Type of change
Checklist
Changes have been:
🤖 AI Disclosure
No AI use