fix(sdks/go): recover durable waits after reconnect - #4448
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
|
Contributor
|
|
Contributor
|
|
igor-kupczynski
marked this pull request as ready for review
July 16, 2026 15:28
grutt
approved these changes
Jul 20, 2026
Keep queued durable requests paired with their waiters until a stream has actually connected, preventing reconnect retries from creating orphaned requests.
igor-kupczynski
force-pushed
the
go-durable-wait-reconnect
branch
from
July 20, 2026 13:39
91d5b0b to
d05cb4c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Go durable waits now report pending callbacks after reconnect and periodically so persisted completions can be replayed.
Why:
How:
WorkerStatusafter connecting.similarity to other SDKs
Python
hatchet/sdks/python/hatchet_sdk/clients/listeners/durable_event_listener.py
Lines 293 to 316 in 522678b
TypeScript
hatchet/sdks/typescript/src/clients/listeners/durable-listener/durable-listener-client.ts
Lines 384 to 404 in 522678b
Fixes #4445
Type of change
What's Changed
Checklist
Changes have been:
Testing
go test -race ./pkg/client -count=1go test ./sdks/go/... -count=1gofmt -d pkg/client/durable_task_listener.go pkg/client/durable_task_listener_test.gogit diff --check -- pkg/client/durable_task_listener.go pkg/client/durable_task_listener_test.go🤖 AI Disclosure
I acknowledge that an LLM was used in the creation of this Pull Request, in accordance with Hatchet's AI_POLICY.md.
Details: Cursor with GPT-5.6 Sol was used to develop and test the implementation and draft this pull request.