fix: Cleanup redundant batch cleanup mechanisms, improve ListDistinctBatchResources query - #4542
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
grutt
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
2 fixes here:
after_v1_task_runtime_delete_cleanup_batch_runtimealready cleans up batch runtime rows once thev1_task_runtimerows are cleaned up, which happens beforereleaseBatchedQueueItemsruns, so we don't need to do it twice.ListDistinctBatchResourcesso it short circuits on the existence of anyv1_batched_queue_itemrow, rather than accumulating all of them. This should help fix worst case performance so that an accumulation of large numbers ofv1_batched_queue_itemrows doesn't impact this queries' performance.Fixes # (issue)
Type of change
What's Changed
Checklist
Changes have been:
🤖 AI Disclosure