TTO-276 Revise queueing order in CRMS #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a custom `PresentationOrder` to the Core project to prioritize mdp namespace. - Add a new `Project#queue_order` used the same way as `PresentationOrder` except: - It applies to the list of candidates being considered for addition to the Queue. - Like `PresentationOrder` the custom `ORDER BY` becomes the first order clause.
moseshll
commented
Nov 6, 2024
| my $sql = 'SELECT * FROM projects WHERE id=?'; | ||
| my $ref = $self->{'crms'}->get('dbh')->selectall_hashref($sql, 'id', undef, $id); | ||
| $self->{$_} = $ref->{$id}->{$_} for keys %{$ref->{$id}}; | ||
| if (defined $id) { |
Collaborator
Author
There was a problem hiding this comment.
I added this so we could create a Project instance without an id (primary key). Normally we never instantiate the Project class, just the subclasses, but this gives me a chance to test the default behavior without writing tests for all of the subclasses (definitely out of scope for this ticket).
moseshll
commented
Nov 6, 2024
mwarin
approved these changes
Nov 7, 2024
mwarin
left a comment
mwarin
left a comment
There was a problem hiding this comment.
Looks fine, nothing that stands in the way of an APPROVE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR for reviewer: a quick scan suffices, read on if fascinated with minutiae.
Note to reviewer: this has been tested on dev-2. This is a somewhat inconsequential tweak to the runtime behavior of the system. Basically we want to promote "mdp" volumes to the front of the queue and the front of the candidates.
PresentationOrderis an existing mechanism (note camel case) andqueue_orderis the new method (note snake case) using almost the same mechanism, just applied to a different query. (The mechanism is embarrassingly clunky but I don't know how else to do it: basically we allow a Project to respond with its ownORDER BYclause that gets plugged into the caller's query.)I have an issue (#195) to change the return values of these subclass methods. Out of scope for this ticket.
PresentationOrderto the Core project to prioritize mdp namespace.Project#queue_orderused the same way asPresentationOrderexcept:PresentationOrderthe customORDER BYbecomes the first order clause.undef.