Conversation
|
@yarl: Thanks! I am curious if there were any changes in the back-end after the hackathon, or the 'close campaign' button has been implemented without the actual possibility of closing the campaign. |
|
@atsirlin no backend changes (from me) yet! I'll review this and then reply your email, @atsirlin, but while I'm here I might as well say thank you for working on this at the hackathon. I was planning on doing more, but I caught a bad cold. Glad you two still got a bunch done, great work! OK reviewing now... |
|
@mahmoud: thank you too, it was a pleasure to meet Pawel and get a bit more familiar with the code! However, it would also be great if someone replies to the e-mail that I sent around after the hackathon... |
mahmoud
left a comment
mahmoud
left a comment
There was a problem hiding this comment.
Lots of formatting changes! One question about URL construction, but otherwise LGTM. Thanks!
| class="md-secondary md-icon-button" | ||
| ng-href="{{ | ||
| '//commons.wikimedia.org/wiki/File:' + | ||
| $ctrl.rating.current.entry.name + |
There was a problem hiding this comment.
is this going to need escaping or is entry.name already url escaped?
There was a problem hiding this comment.
I think we're getting entry.name straight from mediawiki, so it should be URL friendly.
We should have a test for this, though—$ctrl.rating.current.entry.name makes an appearance above, and there is encodeURIComponent(image.entry.name) elsewhere...
|
This is looking good to me. |
@atsirlin could you re-send, if those questions are still unanswered? |
|
I think it's fine for now |
4 participants
I will add list of issues closed soon.