Fix vote later permanently hiding skipped images in voting rounds#378
Open
Oyelakin-Mercy wants to merge 1 commit intohatnote:masterfrom
Open
Fix vote later permanently hiding skipped images in voting rounds#378Oyelakin-Mercy wants to merge 1 commit intohatnote:masterfrom
Oyelakin-Mercy wants to merge 1 commit intohatnote:masterfrom
Conversation
Oyelakin-Mercy
force-pushed
the
fix/vote-later-bug
branch
from
aef8e27 to
cee1e1b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #371 and #372
This PR fixes the "Vote Later" bug that hid images permanently from being attended to later in the yes/no and rating rounds. It showed "all done" on the Juror's end when it was not actually complete, and less than 100% on the organizer's end, which led to not being able to finalize the round.
This has now been fixed with the following changes:
montage/rdb.py:Updatedskip_votingto store skipped vote IDs as a list instead of a single value, so multiple images can be skipped without replacing each other.montage/rdb.py:Updatedget_tasks_from_roundto display the non-skipped tasks first, and only return skipped tasks when all other tasks are complete, so the skipped images are always re-queued for the juror to vote on later.Before:
After:
