Skip to content

Fix #18: Show round directions in juror voting interface#405

Closed
QuantumPrity wants to merge 5 commits intohatnote:masterfrom
QuantumPrity:fix/issue-18-show-directions-voting
Closed

Fix #18: Show round directions in juror voting interface#405
QuantumPrity wants to merge 5 commits intohatnote:masterfrom
QuantumPrity:fix/issue-18-show-directions-voting

Conversation

@QuantumPrity
Copy link
Copy Markdown

Fixes #18

Problem

Jurors had no way to see round directions/instructions while voting.
The directions were being saved by coordinators but never displayed
in the voting interface.

Solution

Added a directions display section at the top of the voting interface
in Vote.vue. The directions are already sent by the backend in
juror_endpoints.py so no backend changes were needed.

Changes

  • frontend/src/components/Vote/Vote.vue — Added directions display
  • frontend/src/i18n/en.json — Added translation key

Screenshots

(Before)
Screenshot (250)

(After)
Screenshot (251)

Screenshot (252)

Note: Unable to provide live app screenshots as the app requires
Wikipedia OAuth setup locally. The before screenshot shows the
code without directions display, and the after screenshot shows
the updated code with directions display in Vote.vue.

@lgelauff
Copy link
Copy Markdown
Collaborator

To test this locally without OAuth, you can use the project's debug login mode:

  1. In config.dev.yaml, set debug: true, debug_username: Effeietsanders, debug_userid: 409
  2. Start the backend: make start (wait for Debugger PIN in logs)
  3. Start the frontend: npm run dev from frontend/
  4. Log in by navigating directly to http://localhost:5001/complete_login — do not use the login
    button, which triggers OAuth
  5. Go to http://localhost:5173 and create a campaign with a round that has directions set
  6. To test as a juror, add yourself as a juror and activate the round, then navigate to the voting
    interface

See docs/dev.md for full setup instructions.

@lgelauff
Copy link
Copy Markdown
Collaborator

This PR appears to have picked up changes from your other open PRs (#401, #402) — likely a branching issue where this branch was created from another feature branch rather than from master. config.default.yaml and package-lock.json also have unrelated local changes committed.

For future PRs: branch from master and keep each PR scoped to a single issue. This makes review easier and keeps git history clean.

For the specific PR: please clean it up, and add a screen recording of the new feature in use. That will greatly help evaluation.

@lgelauff
Copy link
Copy Markdown
Collaborator

I was able to spin up the change locally, and it looks something like this.
Screenshot 2026-04-12 at 1 03 54 PM

It's not a solution that would work very well, because the instructions could be several paragraphs. I dont think it's necessary either that the text is always visible, but it should be reachable (click a button and get a popup). Could you propose a design for that?

@QuantumPrity
Copy link
Copy Markdown
Author

Hi @Igelauff,

I have opened a new, clean Pull Request at #493 that addresses the branching issues and keeps the git history scoped strictly to the Vote.vue changes.

I am closing this PR to keep the repository organized. All further updates and the screen recording will be posted on #493. Thank you for the guidance on keeping the PRs focused!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Easy access voting instructions

3 participants