fix(admin): finalize round via DAO close path#491
Open
userAdityaa wants to merge 1 commit intohatnote:masterfrom
Open
fix(admin): finalize round via DAO close path#491userAdityaa wants to merge 1 commit intohatnote:masterfrom
userAdityaa wants to merge 1 commit intohatnote:masterfrom
Conversation
Author
|
@lgelauff, would appreciate your thoughts on the improvements. |
ayushshukla1807
pushed a commit
to ayushshukla1807/montage
that referenced
this pull request
Apr 12, 2026
- Moved RoundResultsSummary creation from finalize_ranking_round to finalize_campaign as requested by maintainer. - Created generic CoordinatorDAO.finalize_round method to ensure consistent status updates, close_date injection, and audit logging. - Updated admin_endpoints.py to delegate to the new DAO method, resolving the bypass issue. - Integrated regression test from PR hatnote#491 to ensure technical parity and future stability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The admin finalize round endpoint was directly mutating round status, which skipped round-close side effects. This change introduces a dedicated DAO close-round method and delegates the endpoint to it.
Verification
Solution directly follows the feedback given in #463 (comment)
Closes #462
Screenshots of UI Validation