fix(frontend): set empty VITE_API_ENDPOINT for production builds#515
Merged
lgelauff merged 1 commit intomontage-devfrom Apr 20, 2026
Merged
fix(frontend): set empty VITE_API_ENDPOINT for production builds#515lgelauff merged 1 commit intomontage-devfrom
lgelauff merged 1 commit intomontage-devfrom
Conversation
When building on Toolforge, .env is gitignored so VITE_API_ENDPOINT is undefined, making Axios baseURL resolve to "undefined/v1/" and breaking all API calls. .env.production sets it to empty so the baseURL correctly resolves to "/v1/" (same-domain relative path). Fixes Toolforge deployments broken since #277 (Add CORS). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Verified working on montage-dev (2026-04-20): built with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
frontend/.env.productionwithVITE_API_ENDPOINT=(empty string).envis gitignored on Toolforge soVITE_API_ENDPOINTisundefined, making Axios baseURL resolve toundefined/v1/and breaking all API calls/v1/as a relative same-domain baseURLTest plan
toolforge jobs run npm-build --image node20 --mem 4Gi --wait --command "cd $HOME/www/python/src/frontend && npm run toolforge:build"undefined/v1/errors in browser console🤖 Generated with Claude Code