Skip to content

Added the HazelcastClient::version API. #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Added the HazelcastClient::version API. #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9de8a27
Added the `version()` API.
ihsandemir Oct 27, 2020
d9b30c7
Merge branch 'master' into versionAPI
ihsandemir Oct 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions hazelcast/include/hazelcast/client/HazelcastClient.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
*/
#pragma once

#include <boost/utility/string_view.hpp>

#include "hazelcast/client/impl/HazelcastClientInstanceImpl.h"

#if defined(WIN32) || defined(_WIN32) || defined(WIN64) || defined(_WIN64)
Expand Down Expand Up @@ -289,11 +291,24 @@ namespace hazelcast {
*/
spi::LifecycleService &getLifecycleService();

/**
*
* @return the CP subsystem that offers a set of in-memory linearizable data structures
*/
cp::cp_subsystem &get_cp_subsystem();

private:
std::shared_ptr<impl::HazelcastClientInstanceImpl> clientImpl;
};

/**
*
* @return the version of the client
*/
constexpr boost::string_view version() {
return HAZELCAST_VERSION;
}

}
}

Expand Down
17 changes: 0 additions & 17 deletions hazelcast/test/src/HazelcastTests1.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,11 +896,6 @@ namespace hazelcast {
}
}






namespace hazelcast {
namespace client {
namespace test {
Expand Down Expand Up @@ -1043,10 +1038,6 @@ namespace hazelcast {
}
}





namespace hazelcast {
namespace client {
namespace test {
Expand Down Expand Up @@ -1111,9 +1102,6 @@ namespace hazelcast {
}
}




namespace hazelcast {
namespace client {
namespace test {
Expand All @@ -1140,9 +1128,6 @@ namespace hazelcast {
}
}




namespace hazelcast {
namespace client {
namespace test {
Expand Down Expand Up @@ -2787,8 +2772,6 @@ namespace hazelcast {
}
}



namespace hazelcast {
namespace client {
namespace test {
Expand Down
3 changes: 0 additions & 3 deletions hazelcast/test/src/HazelcastTests5.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,6 @@ namespace hazelcast {
}
*/


namespace hazelcast {
namespace client {

Expand Down Expand Up @@ -389,7 +388,6 @@ namespace hazelcast {
}
}


namespace hazelcast {
namespace client {

Expand Down Expand Up @@ -505,7 +503,6 @@ namespace hazelcast {
}
}


namespace hazelcast {
namespace client {

Expand Down
5 changes: 5 additions & 0 deletions hazelcast/test/src/HazelcastTests8.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1607,6 +1607,11 @@ namespace hazelcast {
namespace hazelcast {
namespace client {
namespace test {
class VersionTest: public ClientTestSupport {};
TEST_F(VersionTest, test_client_version) {
ASSERT_EQ(HAZELCAST_VERSION, version());
}

class ClientMessageTest: public ClientTestSupport {
protected:
struct BufferedMessageHandler {
Expand Down