Change configuration to keyword arguments #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
mdumandag
force-pushed
the
config-update
branch
from
566260e to
4bcce2d
Compare
This PR replaces Java-style `ClientConfig` class with keyword-arguments. It also updates README, code samples and tests with the new configuration style. The full list of supported keyword arguments can be seen on the `hazelcast.config._Config` class. Apart from them, - `enum`s are changed to `EnumName.ITEM_NAME` format. - IDEs now show the possible values of `enum`s. - All config options now assume time unit in seconds. - `cloud_config.enabled` is removed. Cloud discovery is enabled once the discovery token is set. - Extra tests are added for `_IndexConfig` and `_IndexUtil`. - Load balancers are moved to the `util`, similar to the Java client.
mdumandag
force-pushed
the
config-update
branch
from
4bcce2d to
f0af80b
Compare
sancar
approved these changes
Oct 8, 2020
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Dec 11, 2020
We forget to update the code that sets socket options while doing hazelcast#219. The code now handles the given socket options tuple correctly. Also, added some tests that verifies this.
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Dec 11, 2020
We forget to update the code that sets socket options while doing hazelcast#219. The code now handles the given socket options tuple correctly. Also, added some tests that verifies this.
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Dec 11, 2020
We forget to update the code that sets socket options while doing hazelcast#219. The code now handles the given socket options tuple correctly. Also, added some tests that verifies this.
mdumandag
added a commit
to mdumandag/hazelcast-python-client
that referenced
this pull request
Dec 11, 2020
We forget to update the code that sets socket options while doing hazelcast#219. The code now handles the given socket options tuple correctly. Also, added some tests that verifies this.
mdumandag
added a commit
that referenced
this pull request
Dec 11, 2020
We forget to update the code that sets socket options while doing #219. The code now handles the given socket options tuple correctly. Also, added some tests that verifies this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #218
This PR replaces Java-style
ClientConfigclass with keyword-arguments.It also updates README, code samples, and tests with the new configuration
style. The full list of supported keyword arguments can be seen in the
hazelcast.config._Configclass. Documentation for the keyword arguments will be added in a latter PR when we switch to the Google style docstrings(#221 ).Apart from them,
enums are changed toEnumName.ITEM_NAMEformat.enums.cloud_config.enabledis removed. Cloud discovery is enabled once thediscovery token is set.
_IndexConfigand_IndexUtil.util, similar to the Java client.SSLProtocol.SSLandSSLProtocol.TLSare removed. One has to give the exact version to be used now