Fix setting configured socket options #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdumandag
force-pushed
the
socket-options-handling
branch
from
8d54837 to
eb6509f
Compare
We forget to update the code that sets socket options while doing hazelcast#219. The code now handles the given socket options tuple correctly. Also, added some tests that verifies this.
mdumandag
force-pushed
the
socket-options-handling
branch
from
eb6509f to
a4f2d11
Compare
puzpuzpuz
approved these changes
Dec 11, 2020
Contributor
Author
|
Thanks a lot for the review Andrey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We forget to update the code that sets socket options while doing #219.
The code now handles the given socket options tuple correctly. Also,
added some tests that verifies this.