Skip to content

Signup config load fix - #799

Merged
aplatoff merged 1 commit into
mainfrom
signup_config_fix
Jan 11, 2022
Merged

Signup config load fix#799
aplatoff merged 1 commit into
mainfrom
signup_config_fix

Conversation

@BykhovDenis

@BykhovDenis BykhovDenis commented Jan 11, 2022

Copy link
Copy Markdown
Member

Signed-off-by: Denis Bykhov 80476319+BykhovDenis@users.noreply.github.com

Signed-off-by: Denis Bykhov <80476319+BykhovDenis@users.noreply.github.com>
@BykhovDenis
BykhovDenis requested a review from aplatoff January 11, 2022 13:56
@BykhovDenis BykhovDenis self-assigned this Jan 11, 2022
@BykhovDenis BykhovDenis changed the title Fix Signup config load fix Jan 11, 2022
Comment thread dev/prod/src/platform.ts
export async function configurePlatform() {
await fetch('/config.json').then(config => {
config.json().then(value => {
await fetch('/config.json').then(async (config) => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not

const config = await fetch(...)
...

@aplatoff
aplatoff merged commit d7e1c44 into main Jan 11, 2022
@aplatoff
aplatoff deleted the signup_config_fix branch January 11, 2022 16:08
MichaelUray pushed a commit to MichaelUray/huly-platform that referenced this pull request Jul 9, 2026
Signed-off-by: Denis Bykhov <80476319+BykhovDenis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants