Fix error for message without translation #10152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
ArtyomSavchenko
requested review from
aonnikov,
Copilot,
haiodo and
kristina-fefelova
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an error that occurs when a message translation is not a string value. The code now includes type checking before attempting to call .trim() on translation values, preventing runtime errors when message.translates?.[translateTo] returns a non-string value.
Key Changes:
- Added explicit type checking for translation values before calling string methods
- Applied the fix to both
hasTranslateandgetMessageTranslationfunctions
|
Connected to Huly®: UBERF-13992 |
haiodo
approved these changes
Oct 27, 2025
aonnikov
approved these changes
Oct 27, 2025
BykhovDenis
approved these changes
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.