Skip to content

Fix error for message without translation #10152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
Merged

Fix error for message without translation #10152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions plugins/communication-resources/src/stores.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@ export function hasTranslate (

if (translateTo == null || translateTo === '') return false
if (message.language != null && dontTranslate.includes(message.language)) return false
const res = (message.translates?.[translateTo] ?? '').trim()
const translated = message.translates?.[translateTo]
const res = typeof translated === 'string' ? translated.trim() : ''

return res !== ''
}
Expand Down Expand Up @@ -138,7 +139,8 @@ export function getMessageTranslation (

if (translateTo == null || translateTo === '') return undefined
if (message.language != null && dontTranslate.includes(message.language)) return undefined
const res = (message.translates?.[translateTo] ?? '').trim()
const translated = message.translates?.[translateTo]
const res = typeof translated === 'string' ? translated.trim() : ''

return res !== '' ? toMarkup(res) : undefined
}
Expand Down