Skip to content

Conversation

@ArtyomSavchenko
Copy link
Member

No description provided.

Signed-off-by: Artem Savchenko <armisav@gmail.com>
@huly-github-staging
Copy link

Connected to Huly®: UBERF-14216

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes three Analytics.handleError() calls from expected invite validation errors in the checkInvite function to prevent spamming Uptrace (the error monitoring service) with errors that are expected business logic validation failures.

  • Removes error tracking for invite limit exceeded, expired invite links, and email mismatch validation errors
  • Retains ctx.error() logging for all validation failures
  • Aligns error handling with the codebase pattern where Analytics.handleError() is reserved for unexpected errors only
Comments suppressed due to low confidence (1)

server/account/src/utils.ts:1125

  • The commented-out code at line 1124 still contains Analytics.handleError() for an expected validation error. If this code is ever re-enabled, the Analytics.handleError() call should be removed to maintain consistency with the changes in this PR.
  //   ctx.error("Invite doesn't allow this email address", { email, ...invite })
  //   Analytics.handleError(new Error(`Invite link email mask check failed ${invite.id} ${email} ${invite.emailPattern}`))
  //   throw new PlatformError(new Status(Severity.ERROR, platform.status.Forbidden, {}))

@ArtyomSavchenko ArtyomSavchenko merged commit a6c964a into develop Nov 22, 2025
20 of 21 checks passed
@BykhovDenis BykhovDenis deleted the fix-invite-spam branch November 23, 2025 16:29
ArtyomSavchenko added a commit that referenced this pull request Nov 25, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants