Fix uptrace error e.dataset is undefined #10251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artem Savchenko <armisav@gmail.com>
|
Connected to Huly®: UBERF-14244 |
Copilot finished reviewing on behalf of
ArtyomSavchenko
November 25, 2025 04:09
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime error where dataset property could be undefined on an HTMLElement, causing "e.dataset is undefined" errors in Uptrace monitoring. The fix adds optional chaining to safely access the dataset property.
- Added optional chaining operator (
?.) to safely accessdatasetproperty on HTMLElement
aonnikov
approved these changes
Nov 25, 2025
ArtyomSavchenko
added a commit
that referenced
this pull request
Nov 25, 2025
Signed-off-by: Artem Savchenko <armisav@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.