feat(notification-resources): add keyboard shortcuts and a11y semantics to inbox settings popup#10614
Merged
ArtyomSavchenko merged 1 commit intohcengineering:developfrom Mar 11, 2026
Conversation
|
Connected to Huly®: UBERF-15840 |
Signed-off-by: SaiVaraprasad Medapati <varaprasadreddy9676@gmail.com>
varaprasadreddy9676
force-pushed
the
codex/inbox-settings-shortcuts-a11y
branch
from
7b13afc to
a4d240e
Compare
ArtyomSavchenko
approved these changes
Mar 10, 2026
haiodo
pushed a commit
to haiodo/foundation
that referenced
this pull request
Mar 28, 2026
…ing#10614) Signed-off-by: SaiVaraprasad Medapati <varaprasadreddy9676@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhance keyboard interaction and accessibility semantics in the inbox settings popup.
Changes
Home-> first settingEnd-> last settingSpace-> toggle selected setting (same asEnter)selectIndex(bounded selection)toggleSelectedItem(single-path toggle behavior)role="dialog"aria-label="Inbox settings"Files
plugins/notification-resources/src/components/inbox/SettingsPopup.svelteWhy
This aligns popup behavior with common keyboard expectations and improves assistive-technology support.
Testing
ArrowUp/ArrowDownmoves selectionHome/Endjumps to first/last settingEnter/Spacetoggles selected settingTabcloses popup (existing behavior)