Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jun 15, 2022

Contribution checklist

Brief description

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

closes TSK-33

Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
@ghost ghost requested a review from BykhovDenis June 15, 2022 10:52
@ghost ghost marked this pull request as draft June 15, 2022 10:52
Sergei Ogorelkov added 6 commits June 16, 2022 10:20
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>

# Conflicts:
#	common/config/rush/pnpm-lock.yaml
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
Signed-off-by: Sergei Ogorelkov <sergei.ogorelkov@xored.com>
@ghost ghost requested a review from haiodo June 16, 2022 11:01
@ghost ghost marked this pull request as ready for review June 16, 2022 11:02
@haiodo haiodo merged commit e0853ec into main Jun 17, 2022
@haiodo haiodo deleted the sub-issues-project branch June 17, 2022 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant