Skip to content

UBER-504: fix presenters on ListItem. Add DeviceSizes.#3463

Merged
haiodo merged 2 commits intomainfrom
fix-listitem
Jun 28, 2023
Merged

UBER-504: fix presenters on ListItem. Add DeviceSizes.#3463
haiodo merged 2 commits intomainfrom
fix-listitem

Conversation

@SasLord
Copy link
Copy Markdown
Contributor

@SasLord SasLord commented Jun 26, 2023 •
edited by huly-github-staging bot
Loading

Contribution checklist

Brief description

Снимок экрана 2023-06-27 в 02 05 43 Снимок экрана 2023-06-27 в 23 51 58

Checklist

  • - UI test added to added/changed functionality?
  • - Screenshot is added to PR if applicable ?
  • - Does the code work? Check whether function and logic are correct.
  • - Does Changelog.md is updated with changes?
  • - Does the translations are up to date?
  • - Does it well tested?
  • - Tested for Chrome.
  • - Tested for Safari.
  • - Go through the changed code looking for typos, TODOs, commented LOCs, debugging pieces of code, etc.
  • - Rebase your branch onto master and upstream branch
  • - Is there any redundant or duplicate code?
  • - Are required links are linked to PR?
  • - Does new code is well documented ?

Related issues

A list of closed updated issues

@SasLord
UBER-504: fix presenters on ListItem. Add DeviceSizes.
8c76e8e 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
BykhovDenis
BykhovDenis reviewed Jun 27, 2023
View reviewed changes
Comment thread plugins/view/src/index.ts
key?: string
excludeByKey?: string
fixed?: 'left' | 'right' // using for align items in row
suffix?: boolean
Copy link
Copy Markdown
Member

@BykhovDenis BykhovDenis Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we need it?

Copy link
Copy Markdown
Contributor Author

@SasLord SasLord Jun 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For correct display of AttchmentsPresenter and CommentsPresenter in compact mode

haiodo
haiodo reviewed Jun 27, 2023
View reviewed changes
Comment thread packages/ui/src/components/internal/Root.svelte Outdated
haiodo
haiodo reviewed Jun 27, 2023
View reviewed changes
Comment thread packages/ui/src/components/internal/Root.svelte Outdated
haiodo
haiodo reviewed Jun 27, 2023
View reviewed changes
Comment thread packages/ui/src/types.ts Outdated
haiodo
haiodo reviewed Jun 27, 2023
View reviewed changes
Comment thread plugins/tags-resources/src/components/TagsReferencePresenter.svelte Outdated
@SasLord
Fixes
61d4c14 
Signed-off-by: Alexander Platov <sas_lord@mail.ru>
@haiodo haiodo merged commit c7ade70 into main Jun 28, 2023
@haiodo haiodo deleted the fix-listitem branch June 28, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BykhovDenis BykhovDenis BykhovDenis left review comments

+1 more reviewer

@haiodo haiodo haiodo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SasLord @haiodo @BykhovDenis