Skip to content

UBERF-7765: Only retry network errors when loading config for desktop app #6274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2024
Merged

UBERF-7765: Only retry network errors when loading config for desktop app #6274

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions desktop/src/ui/preload.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,21 +19,27 @@ export function concatLink (host: string, path: string): string {

async function loadServerConfig (url: string): Promise<any> {
let retries = 5
let error: any
let res: Response | undefined

do {
try {
return await (await fetch(url)).json()
res = await fetch(url)
break
} catch (e) {
error = e
retries--
if (retries > 0) {
await new Promise((resolve) => setTimeout(resolve, 1000 * (5 - retries)))
if (retries === 0) {
throw new Error(`Failed to load server config: ${e}`)
}
await new Promise((resolve) => setTimeout(resolve, 1000 * (5 - retries)))
}
} while (retries > 0)

throw new Error(`Failed to load server config: ${error}`)
if (res === undefined) {
// In theory should never get here
throw new Error('Failed to load server config')
}

return await res.json()
}

const openArg = (process.argv.find((it) => it.startsWith('--open=')) ?? '').split('--open=')[1]
Expand Down