Feat: Filter Inline Command List With User Input #6940
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Om Jogani <om080jogani@gmail.com>
omjogani
force-pushed
the
feat/filter-inline-command-list
branch
from
53cc58d to
0ff1e89
Compare
Signed-off-by: omjogani <om080jogani@gmail.com>
omjogani
force-pushed
the
feat/filter-inline-command-list
branch
from
0ff1e89 to
3bf06bd
Compare
Collaborator
|
Hello @omjogani, thanks for your interest in contributing to Huly. To pass the automatic checks all the commits must be marked with DCO as described here https://github.com/apps/dco. |
lexiv0re
reviewed
Oct 15, 2024
| // to handle case of `todo-list` and `action-item` being the same | ||
| const searchableItems = items.map(item => | ||
| item.id === 'todo-list' | ||
| ? { ...item, searchLabels: ['action-item', textEditor.string.TodoList] } |
Collaborator
There was a problem hiding this comment.
Using internal text keys as a search condition won't work well. Users will expect the search to work for what they see in the menu so for the interface in english it may poorly work in some cases (where the text doesn't match the key) and for the interface in other languages it won't work at all. Please consider searching by translated texts.
Contributor
|
Closing as outdated. |
Member
|
Closing as outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the current version of the product, typing / within a document brings up an inline command list, but the list does not filter as you continue typing.
What Does This PR Address?
This PR introduces functionality that allows the inline command list to filter items dynamically as you type text following the / symbol.
For more details, please refer to the video below, which demonstrates the issue that this PR resolves.
Video Demonstration (Before)
Before.Changes.mp4
Video Demonstration (After)
After.Changes.mp4
Thanks!