Fix hideAdd does not prevent adding by keyboard on TagsPopup#7246
Merged
haiodo merged 1 commit intohcengineering:developfrom Feb 24, 2025
Merged
Conversation
aonnikov
approved these changes
Jan 27, 2025
Member
|
@haiodo any idea why we don't have "Approve and Run" button to trigger CI for this pull request? |
Signed-off-by: Andre Henriques <contact@andr3h3nriqu3s.com>
haiodo
force-pushed
the
fix-tags-popup-hide-add
branch
from
87cbcf0 to
304db3e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While looking to the code of
TagsPopup, to make it work with keyboard only, I noticed that thehideAddprop does not prevent the creating of a new tag via the keyboard.