Skip to content

Smooth appearance of the tooltip (fixed twitching) #8617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haiodo merged 2 commits into from
Apr 18, 2025
Merged

Smooth appearance of the tooltip (fixed twitching) #8617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f05258
Smooth appearance of the tooltip (fixed twitching)
SasLord Apr 17, 2025
59a54ba
Fix test
SasLord Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions packages/ui/src/components/TooltipInstance.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import Component from './Component.svelte'
import Label from './Label.svelte'
import { capitalizeFirstLetter, formatKey } from '../utils'
import { testing } from '..'

let tooltipHTML: HTMLElement
let nubHTML: HTMLElement
Expand Down Expand Up @@ -248,6 +249,7 @@

const hideTooltip = (): void => {
if (tooltipHTML) options.visibility = 'hidden'
shown = false
closeTooltip()
}

Expand Down Expand Up @@ -319,6 +321,7 @@
{#if $tooltip.component && $tooltip.kind !== 'submenu'}
<div
class="popup-tooltip {options.classList} {$tooltip.style}"
class:testing
class:shown
class:doublePadding={$tooltip.label}
use:resizeObserver={(element) => {
Expand Down Expand Up @@ -374,6 +377,7 @@
bind:this={nubHTML}
style:z-index={($modals.findIndex((t) => t.type === 'tooltip') ?? 1) + 10000}
class="nub {nubDirection ?? ''}"
class:testing
class:shown
/>
{/if}
Expand Down Expand Up @@ -467,7 +471,6 @@
border-radius: 0.75rem;
box-shadow: var(--theme-popup-shadow);
user-select: none;
opacity: 0;

&.doublePadding {
padding: 1rem;
Expand All @@ -489,13 +492,25 @@
background-color: var(--popup-color-disabled);
}
}
.popup-tooltip,
.nub {
opacity: 0;
transition: opacity 0.1s ease-in-out;

&.testing {
transition-duration: 0 !important;
}
}
.shown {
opacity: 1;
transition: opacity 0.1s ease-in-out 0.05s;
}

.nub {
position: fixed;
// background-color: rgba(255, 255, 0, .5);
user-select: none;
pointer-events: none;
opacity: 0;

&::after,
&::before {
Expand Down Expand Up @@ -561,10 +576,6 @@
transform: rotate(-90deg);
}
}
.shown {
transition: opacity 0.1s ease-in-out 0.15s;
opacity: 1;
}

.keys {
margin-left: 0.5rem;
Expand Down
2 changes: 1 addition & 1 deletion tests/sanity/tests/documents/documents-content.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ test.describe('Content in the Documents tests', () => {
await documentContentPage.changeCodeBlockLanguage('Line 18', 'plaintext', 'css')
await documentContentPage.applyNote('Line 19', 'warning', testNote)
await documentContentPage.addImage('Line 20')
await page.keyboard.type('Cat')
// await page.keyboard.type('Cat')

newUser2 = generateUser()
await createAccount(request, newUser2)
Expand Down