Pass aws_region in ros3 tests for libhdf5 2.0 compatibility#1471
Merged
Conversation
libhdf5 2.0 made aws_region a required parameter for the ROS3 driver, breaking the conda-forge hdmf 6.0.0 release tests. Update the ROS3 streaming tests to always pass aws_region and bump environment-ros3.yml to install libhdf5 >= 2.0 so CI exercises the new behavior. Fixes #1470 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1471 +/- ##
==========================================
- Coverage 93.20% 93.18% -0.02%
==========================================
Files 41 41
Lines 10176 10176
Branches 2103 2103
==========================================
- Hits 9485 9483 -2
Misses 415 415
- Partials 276 278 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oruebel
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/test_io_hdf5_streaming.pyto always passaws_region, since libhdf5 2.0 made it required for the ROS3 driver. The previously redundant no-region tests are removed and the_with_aws_regionvariants are renamed to take their place.environment-ros3.ymltoh5py==3.16.0and pinshdf5>=2.0so CI exercises the libhdf5 2.x ROS3 path (the previous pin resolved to libhdf5 1.14.x and never tripped the new region check).Fixes #1470.
Test plan
linux-python3.14-ros3CI job passes against libhdf5 2.x.test_basic_read,test_get_namespaces,test_load_namespaces) no longer appear once this lands in a 6.0.1 release.🤖 Generated with Claude Code