Skip to content

chore: restore stubs/app-modules/.gitkeep#405

Merged
gvieira18 merged 1 commit into
4.xfrom
chore/restore-module-stub-gitkeep
Jul 9, 2026
Merged

chore: restore stubs/app-modules/.gitkeep#405
gvieira18 merged 1 commit into
4.xfrom
chore/restore-module-stub-gitkeep

Conversation

@gvieira18

Copy link
Copy Markdown
Member

Why

config/app-modules.php uses base_path('stubs/app-modules/.gitkeep')
as the source stub that internachi/modular copies into every new
module's placeholder dirs:

'tests/Unit/.gitkeep'          => base_path('stubs/app-modules/.gitkeep'),
'tests/Feature/.gitkeep'       => base_path('stubs/app-modules/.gitkeep'),
'database/factories/.gitkeep'  => base_path('stubs/app-modules/.gitkeep'),
'database/migrations/.gitkeep' => base_path('stubs/app-modules/.gitkeep'),
'database/seeders/.gitkeep'    => base_path('stubs/app-modules/.gitkeep'),

#402 deleted that file, so php artisan make:module now fails when it
tries to copy a non-existent stub source.

What

  • Restore the empty stubs/app-modules/.gitkeep file.

Notes

Only the stub source is restored. The .gitkeep placeholders that
#402 removed from existing modules are left deleted — those dirs now
hold real content, so they no longer need a placeholder.

Source stub referenced by config/app-modules.php for the placeholder
files internachi/modular writes into every new module's tests and
database dirs. #402 removed it, which breaks make:module.
@gvieira18 gvieira18 requested a review from a team July 9, 2026 16:50
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • stubs/app-modules/.gitkeep
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b8e66769-e824-46df-a100-bfbee7e5ef92

📥 Commits

Reviewing files that changed from the base of the PR and between 87db5d3 and 2902f5d.

📒 Files selected for processing (1)
  • stubs/app-modules/.gitkeep

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@gvieira18 gvieira18 merged commit edbf93d into 4.x Jul 9, 2026
10 checks passed
@gvieira18 gvieira18 deleted the chore/restore-module-stub-gitkeep branch July 9, 2026 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant