fix(panel-app): corrige camada do modal de unificação#442
fix(panel-app): corrige camada do modal de unificação#442henrique-leme wants to merge 3 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe merge confirmation modal is teleported to the document body and now handles the window-level Escape key through 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@resources/views/livewire/connection-hub.blade.php`:
- Around line 149-154: Update the modal container identified by x-data="{ open:
true }" to include role="dialog" and aria-modal="true", and add Alpine.js
Escape-key handling that closes the modal by setting open to false. Preserve the
existing visibility and transition behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro
Run ID: 13519f41-fe2f-4fa8-b613-9b01aca11bda
📒 Files selected for processing (1)
resources/views/livewire/connection-hub.blade.php
|
Olá, vi um apontamento do coderabbit sobre acessibilidade, seria ideal adicionar isto |
2158fe4
6 participants
Closes #441
Contexto
O modal de confirmação de unificação era renderizado dentro da coluna lateral sticky. Isso criava um contexto de empilhamento próprio e fazia os campos Apelido e Data de Nascimento aparecerem por cima do modal quando o topo do perfil estava visível.
O que mudou
O modal agora usa o teleport do Livewire para ser renderizado diretamente no body. A lógica de confirmação e cancelamento continua no mesmo componente, mas o modal deixa de ficar preso ao contexto de camadas da coluna lateral.
Testes
php artisan view:cachevendor/bin/pest app-modules/panel-app/tests/Feature/ProfilePageTest.php --compactcom 16 testes e 92 assertionsvendor/bin/pint --test --parallelnpm run buildValidação manual
Testei o modal no topo da página e depois de rolar 700 pixels. A camada escura ficou acima de todo o perfil nos dois casos. O botão Cancelar fechou o modal normalmente e o botão Unificar manteve o binding com
confirmMerge.