Conversation
… pinning) (#378) * fix(security): set DataLoader pin_memory explicitly to avoid undefined pinning Trail of Bits' Semgrep rule `automatic-memory-pinning` (CWE-676) flags `torch.utils.data.DataLoader` calls that leave `pin_memory` unset, since the pinning behaviour is then implicit. Explicitly gate pinning on GPU availability across all 27 DataLoader call sites: pin_memory=torch.cuda.is_available() This pins host memory only when a CUDA device is present (faster, async host->GPU copies) and avoids wasting scarce page-locked memory on CPU-only machines. Previously-hardcoded `pin_memory=True` sites (scgpt, tahoe, transcriptformer) are unified to the same predicate so they no longer pin unconditionally on CPU-only runs. Refs: trailofbits.python.automatic-memory-pinning
oriolpetithelical
requested review from
bputzeys and
maxiallard
and removed request for
maxiallard
July 8, 2026 16:15
oriolpetithelical
changed the title
bump to version 2.1.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trail of Bits' Semgrep rule
automatic-memory-pinning(CWE-676) flagstorch.utils.data.DataLoadercalls that leavepin_memoryunset, since the pinning behaviour is then implicit. Explicitly gate pinning on GPU availability across all 27 DataLoader call sites:This pins host memory only when a CUDA device is present (faster, async host->GPU copies) and avoids wasting scarce page-locked memory on CPU-only machines. Previously-hardcoded
pin_memory=Truesites (scgpt, tahoe, transcriptformer) are unified to the same predicate so they no longer pin unconditionally on CPU-only runs.Refs: trailofbits.python.automatic-memory-pinning