fix(security): move nosemgrep annotation onto np.load call in tahoe blocks - #406
Merged
Merged
Conversation
…locks Place the trailofbits numpy-in-pytorch nosemgrep suppression directly on the np.load(...) line so it targets the actual flagged call rather than the torch.as_tensor wrapper. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GURmbFqmKj4P4BoGEtFcm2
dmiv-helical
approved these changes
Jul 17, 2026
bputzeys
approved these changes
Jul 17, 2026
This was referenced Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the trailofbits
numpy-in-pytorch-modulesnosemgrep suppression comment directly onto thenp.load(...)line inChemEncoderso it annotates the actual flagged call rather than thetorch.as_tensor(...)wrapper.Details
Semgrep's line-level suppression must sit on the line containing the flagged expression. Previously the
# nosemgrepcomment preceded thetorch.as_tensor(call, which is not the numpy operation being flagged. This change places it immediately abovenp.load(drug_fps_path), keeping the existing explanatory comment (helicalAI/dashboard#1154) intact.No functional change.
🤖 Generated with Claude Code