fix: wire up auto_open_panel to AgentPanel starts_open() - #13
Merged
Conversation
The `auto_open_panel` agent setting existed in settings but was never connected to the Panel trait's `starts_open()` method. The default implementation returns false, so the agent panel never auto-opened on workspace creation regardless of the setting value. This was masked by workspace state restoration in persistent sessions but breaks fresh containers (like spectask desktops) where there's no saved workspace state. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
lukemarsden
pushed a commit
that referenced
this pull request
Apr 9, 2026
) When atlas tiles are rapidly allocated and freed (e.g. watching a shared screen in Collab), a texture can become unreferenced and be removed while GPU uploads for it are still pending. On the next frame, `flush_uploads` indexes into the now-empty texture slot and panics: ``` thread 'main' panicked at crates/gpui_wgpu/src/wgpu_atlas.rs:231:40: texture must exist... #11 core::option::expect_failed #12 gpui_wgpu::wgpu_atlas::WgpuAtlas::before_frame #13 gpui_wgpu::wgpu_renderer::WgpuRenderer::draw ``` This change drains pending uploads for a texture when it becomes unreferenced in `remove`, and skips uploads for missing textures in `flush_uploads` as a safety net. Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Release Notes: - Fixed occasional crashes when viewing a screen share
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto_open_panelagent setting existed but was never wired toPanel::starts_open()starts_open()returnsfalse, so the agent panel never auto-opened in fresh containersAgentSettings::get_global(cx).auto_open_panelContext
Fresh spectask containers have
"auto_open_panel": truein settings but no saved workspace state, so the panel stayed closed on boot.Test plan
starts_open)🤖 Generated with Claude Code