Skip to content

Add e2e phases for the production prompt-queue path#66

Merged
lukemarsden merged 1 commit into
mainfrom
feature/002228-unify-all-agent-message
Jul 7, 2026
Merged

Add e2e phases for the production prompt-queue path#66
lukemarsden merged 1 commit into
mainfrom
feature/002228-unify-all-agent-message

Conversation

@lukemarsden

Copy link
Copy Markdown

Summary

The WebSocket-sync e2e drove every phase through the low-level SendChatMessage
primitive. Since Helix now sends all agent messages through the session-scoped
prompt queue (see the companion helix PR), that primitive is no longer the
production send path. This adds two phases that exercise the real production
queue path (EnqueueQueuedPromptprocessPendingPromptsForSession
processPromptQueue / processInterruptPromptsendQueuedPromptToSession)
against a real Zed binary.

Changes

  • Phase 16 — queue busy-defer: start a turn, then enqueue an interrupt=false
    message while it streams; assert it is HELD (no concurrent interaction) and
    delivered as the next turn once idle (the concurrent-mid-turn incident, fixed).
  • Phase 17 — queue interrupt: enqueue an interrupt=true message while a turn
    streams; assert it cancels the running turn (interaction → interrupted) and its
    own message is delivered.
  • Phases poll the store (queue prompts get generated request_ids that don't flow
    through the completion switch) and wait for the first turn to stream before the
    second enqueue.
  • go.mod/go.sum: re-synced with the current helix dependency graph.

Runs green locally (run_docker_e2e.sh, zed-agent): all 17 phases + store
validations PASSED.

Depends on the helix PR (test helper EnqueueQueuedPrompt + in-memory prompt
queue in memorystore); sandbox-versions.txt ZED_COMMIT is bumped there to
this commit.

Release Notes:

  • N/A

🔗 Open in Helix

📋 Spec:

🚀 Built with Helix

Spec-Ref: helix-specs@1ba6cd5e5:002228_complete-the-task-below
@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@lukemarsden lukemarsden merged commit 6799c94 into main Jul 7, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant