Skip to content

Add suggest_dev_container setting to disable dev container suggestions - #7

Merged
lukemarsden merged 1 commit into
mainfrom
feature/001318-in-zed-do-not-offer-to
Feb 21, 2026
Merged

Add suggest_dev_container setting to disable dev container suggestions#7
lukemarsden merged 1 commit into
mainfrom
feature/001318-in-zed-do-not-offer-to

Conversation

@lukemarsden

Copy link
Copy Markdown

Adds a new setting remote.suggest_dev_container (default: true) that controls whether a notification is shown suggesting to open the project in a dev container when a .devcontainer directory is detected.

When set to false, the notification is suppressed. This is useful for platforms like Helix that run Zed inside their own managed containers.

Changes:

  • Added suggest_dev_container field to RemoteSettingsContent schema
  • Added check in suggest_on_worktree_updated() to respect the setting
  • Added suggest_dev_container to RemoteSettings struct
  • Added default value in default.json

Spec-Ref: helix-specs@de1a8873b:001318_in-zed-do-not-offer-to

Adds a new setting `remote.suggest_dev_container` (default: true) that controls
whether a notification is shown suggesting to open the project in a dev container
when a .devcontainer directory is detected.

When set to false, the notification is suppressed. This is useful for platforms
like Helix that run Zed inside their own managed containers.

Changes:
- Added suggest_dev_container field to RemoteSettingsContent schema
- Added check in suggest_on_worktree_updated() to respect the setting
- Added suggest_dev_container to RemoteSettings struct
- Added default value in default.json

Spec-Ref: helix-specs@de1a8873b:001318_in-zed-do-not-offer-to
@lukemarsden
lukemarsden merged commit 746a529 into main Feb 21, 2026
21 checks passed
lukemarsden added a commit that referenced this pull request Mar 23, 2026
… merge

Add 8 previously undocumented upstream file modifications:
- workspace.rs: Agent follow doesn't steal keyboard focus
- migrate.rs: Migration banner hidden in Helix builds
- grep_tool.rs: 500-char line truncation
- context_server_registry.rs: MCP tools-ready tracking
- connection.rs: new wait_for_tools_ready() on AgentConnection trait
- config_options.rs: current_model_value() method
- active_thread.rs: current_model_id() three-way fallback
- thread_view.rs: unregister_thread() on entity replacement

Add 4 new Critical Fixes (#5#7):
- Critical Fix #5: flush stale pending entries when new entry starts
- Critical Fix #6: AcpThread::Stopped invariant (every turn must emit)
- Critical Fix #7: THREAD_REGISTRY unregistration on entity replacement

Update Rebase Checklist from 21 to 30 items.
Update E2E test description: 4 phases → 7 phases, add slow-mcp-server.
Update SyncEvent protocol: entry_type/tool_name/tool_status, mcp_servers/active_model.
Add all 21 commits since last upstream merge to Commit History table.

Release Notes:

- N/A

Spec-Ref: helix-specs@e99b6545f:001554_merge-latest-zed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant