ci: fix first real run — create gen dest dir + Linux overlay dead code#10
Merged
Conversation
cargo-generate's --destination parent directory must already exist; CI never created it, so the generate step failed with 'No such file or directory' on the first real public-runner run. Create it with mkdir -p first (all three jobs).
… clean Every overlay consumer is cfg(target_os=macos), but the submodules were declared unconditionally, so a Linux --features overlay build compiled them with zero users and clippy -D warnings rejected 12 dead-code items. Gate the mods to macOS. macOS still builds + runs all 15 overlay tests; Linux overlay stays a compile-only no-op. Pre-existing since the overlay feature landed; surfaced now that CI runs on Linux for the first time.
hellno
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
The first real CI run (free public runners) surfaced two failures the billing-blocked private CI never caught:
No such file or directory) — cargo-generate's--destinationparent must exist; CI never created it. Fix:mkdir -pit first.--features overlayfailed with 12 dead-code errors — the overlay submodules were declared unconditionally but every consumer is#[cfg(target_os = "macos")], so on Linux they compiled unused and clippy-D warningsrejected them. Fix: gate the submodules to macOS (the feature is macOS-only in v1). Pre-existing bug.Definition of Done
clippy --features tray,overlay -D warningsclean + 15 overlay tests pass.